Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON_RUFF_FORMAT #4329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PYTHON_RUFF_FORMAT #4329

wants to merge 1 commit into from

Conversation

nvuillam
Copy link
Member

Fixes #3295

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 1 0 1.72s
⚠️ BASH bash-exec 6 1 0.02s
✅ BASH shellcheck 6 0 0.19s
✅ BASH shfmt 6 0 0 0.55s
✅ COPYPASTE jscpd yes no 4.71s
✅ DOCKERFILE hadolint 129 0 23.71s
✅ JSON jsonlint 20 0 0.24s
✅ JSON v8r 22 0 30.07s
⚠️ MARKDOWN markdownlint 266 0 299 23.51s
✅ MARKDOWN markdown-table-formatter 266 0 0 187.52s
⚠️ PYTHON bandit 213 66 3.85s
✅ PYTHON black 213 0 0 5.41s
✅ PYTHON flake8 213 0 2.65s
✅ PYTHON isort 213 0 0 1.31s
✅ PYTHON mypy 213 0 16.75s
✅ PYTHON pylint 213 0 34.33s
✅ PYTHON ruff 213 0 0 0.83s
✅ REPOSITORY checkov yes no 33.44s
✅ REPOSITORY git_diff yes no 0.65s
⚠️ REPOSITORY grype yes 25 15.51s
✅ REPOSITORY secretlint yes no 14.42s
✅ REPOSITORY trivy yes no 19.31s
✅ REPOSITORY trivy-sbom yes no 0.33s
⚠️ REPOSITORY trufflehog yes 1 62.52s
✅ SPELL cspell 715 0 13.24s
⚠️ SPELL lychee 348 11 25.63s
✅ XML xmllint 3 0 0 0.82s
✅ YAML prettier 160 0 0 3.39s
✅ YAML v8r 102 0 225.11s
✅ YAML yamllint 161 0 2.68s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Nov 30, 2024

How did you plan on communicating the changes? As having it enabled will causes changes that black wants to contradict (on one of my repos I tried this year). There isn't a format that satisfies both at the same time.

What would be our default config?

@nvuillam
Copy link
Member Author

nvuillam commented Dec 5, 2024

@echoix good remark ! :):

I think it would be disabled by default, and could be activated using some variable like PYTHON_DEFAULT_STYLE, like we do for JAVASCRIPT_DEFAULT_STYLE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix Awaiting requested review from echoix echoix is a code owner

@bdovaz bdovaz Awaiting requested review from bdovaz bdovaz is a code owner

@Kurt-von-Laven Kurt-von-Laven Awaiting requested review from Kurt-von-Laven Kurt-von-Laven is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruff run format command
2 participants
@nvuillam @echoix